codeconsole commented on PR #16215: URL: https://github.com/apache/grails-core/pull/16215#issuecomment-5404854110
Closing. This does not fix #16217, and the mechanism it was opened on turned out to be wrong - the failure reproduced on this very branch, at the wait *after* the click, with the form verified as filled. What is left here guards against a document being replaced while the form is filled. That can happen in principle, and an empty `required` form is silently unsubmittable, but it has not been observed in this application - so it is hardening against something nobody has seen, which is not worth carrying. The evidence is recorded in #16217: the form reaches the server without a session cookie, established by comparing the captured page against injected faults. Anyone picking that up should start there rather than from this branch. The one piece worth doing separately is the diagnostic that issue asks for - capturing the browser's cookies and url into the Geb report when the wait fails - which would settle the open question on the next occurrence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
