Copilot commented on code in PR #36: URL: https://github.com/apache/grails-intellij-plugin/pull/36#discussion_r3864108496
########## plugin/testdata/grails/oldCompletion/gsp/groo1.test: ########## @@ -7,8 +7,12 @@ char checkBox class cleanup +collect +collect Review Comment: The expected completion list contains the entry `collect` twice, which likely indicates accidental duplication in the test expectations (or it masks a duplication bug in completion output). The expected list should generally not contain duplicates unless there is a strong reason. ########## plugin/testdata/grails/oldCompletion/gsp/groo4.test: ########## @@ -10,5 +10,7 @@ render renderErrors request resource +respondsTo +respondsTo Review Comment: The expected completion list contains `respondsTo` twice. Unless duplicates are intentional, this should be de-duplicated to keep the test verifying unique completion variants. ########## plugin/testdata/grails/oldCompletion/gsp/groo3.test: ########## @@ -10,4 +10,6 @@ render renderErrors request resource +respondsTo +respondsTo Review Comment: The expected completion list contains `respondsTo` twice. Unless the completion UI is intentionally showing duplicate lookup strings, this is probably an accidental duplication in the expected results and reduces the signal of this regression test. ########## plugin/testdata/grails/oldCompletion/gsp/groo5.test: ########## @@ -14,5 +14,7 @@ render renderErrors request resource +respondsTo +respondsTo Review Comment: The expected completion list contains `respondsTo` twice. This looks like an accidental duplication in the expected output; keeping duplicates here can either fail on correct behavior (deduped completions) or mask a completion duplication bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
