codeconsole commented on code in PR #16149:
URL: https://github.com/apache/grails-core/pull/16149#discussion_r3874230401
##########
grails-web-common/src/main/groovy/org/grails/web/servlet/mvc/GrailsWebRequest.java:
##########
@@ -214,14 +260,14 @@ public FlashScope getFlashScope() {
/**
* @return The currently executing request
+ *
+ * @deprecated as of 8.0, use {@link #getRequest()} instead. This used to
return the resolved
+ * multipart request in place of the request Grails was bound
to; that substitution is
+ * gone, so the two are now the same object.
*/
+ @Deprecated(since = "8.0")
Review Comment:
Because there is no point of having 2 methods that do the same thing. We
can't get rid of getRequest() that is inherited and without the multipart check
(which is no longer needed) getCurrentRequest() is the same as getRequest()
before
```groovy
public HttpServletRequest getCurrentRequest() {
if (multipartRequest != null) {
return multipartRequest;
}
else {
return getRequest();
}
}
```
after this PR
```groovy
public HttpServletRequest getCurrentRequest() {
return getRequest();
}
```
what is the point in keeping it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
