Copilot commented on code in PR #16238:
URL: https://github.com/apache/grails-core/pull/16238#discussion_r3881800315
##########
grails-forge/grails-forge-api/src/main/java/org/grails/forge/api/GrailsForgeConfiguration.java:
##########
@@ -75,7 +76,9 @@ public String getRedirectUrl() {
* @param redirectUri The redirect URI
*/
public void setRedirectUrl(@Nullable String redirectUri) {
- this.redirectUrl = redirectUrl;
+ if (redirectUri != null) {
+ this.redirectUrl = redirectUri;
+ }
}
Review Comment:
The setter is named `setRedirectUrl`, but its parameter is named
`redirectUri`. Renaming the parameter to `redirectUrl` would reduce confusion
and match both the field name and method name (the Javadoc also refers to a
URL).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
