Copilot commented on code in PR #16257: URL: https://github.com/apache/grails-core/pull/16257#discussion_r3883818659
########## grails-forge/docs/aws-elastic-beanstalk.md: ########## @@ -163,13 +163,11 @@ curl --fail --show-error --silent \ "https://${SLOT_HOSTNAME}/versions"; ``` -Repeat for all five hostnames. Success proves certificate selection, SNI, the host rule, target reachability, and the slot response before public DNS changes. +Repeat for all five hostnames. Success proves certificate selection, SNI, the host rule, and target reachability. Public DNS already CNAME's these hostnames to the ALB, so the same check works without `--connect-to`. Review Comment: The phrase "Public DNS already CNAME's these hostnames" is grammatically incorrect in documentation. Use "CNAMEs" (plural) or rephrase to "has DNS-only CNAME records" to avoid the apostrophe. ########## RELEASE.md: ########## @@ -318,18 +318,27 @@ the date you moved the distribution artifacts and report the release. ### Deploy the release to Grails Forge -Publish the released version to [Grails Forge](https://start.grails.org) using one of the [GCP Deploy Actions](https://github.com/apache/grails-core/actions) available in the `grails-core` repository. +Publish the released version to [Grails Forge](https://start.grails.org) using [Forge - AWS Elastic Beanstalk Deploy](https://github.com/apache/grails-core/actions/workflows/forge-deploy-aws.yml). -Grails Forge organizes deployments into version slots as follows: +There is one workflow and two choices: **Use workflow from** (the maintenance branch to build) and **slot**. -- **RELEASE** - Full Final Releases - https://github.com/apache/grails-core/actions/workflows/forge-deploy-release.yml -- **NEXT** - Milestones and Release Candidate for Next Release (also Next version snapshot prior to Milestone) - https://github.com/apache/grails-core/actions/workflows/forge-deploy-next.yml -- **SNAPSHOT** - current or next version snapshot - https://github.com/apache/grails-core/actions/workflows/forge-deploy-snapshot.yml -- **PREV** - previous release version - https://github.com/apache/grails-core/actions/workflows/forge-deploy-prev.yml -- **PREV-SNAPSHOT** - previous version snapshot - https://github.com/apache/grails-core/actions/workflows/forge-deploy-prev-snapshot.yml +| Slot | Host | Typical branch | +| --- | --- | --- | +| `latest` | `latest.grails.org` | current release line, for example `7.2.x` | +| `snapshot` | `snapshot.grails.org` | current snapshot line, for example `8.0.x` | +| `next` | `next.grails.org` | milestone / RC line | +| `prev` | `prev.grails.org` | previous release line | +| `prev-snapshot` | `prev-snapshot.grails.org` | previous snapshot line | -Use the action whose name matches the slot you want to deploy to.\ -In the **“Run workflow/Use workflow from”** dropdown, choose the release tag you just created. +Do not select a historical git tag in **Use workflow from**. The AWS workflow file is not on old tags. Snapshot slots can deploy from the maintenance branch. + +A tagged release that must match an exact tag is packaged locally, then uploaded to Elastic Beanstalk. From a checkout of that tag, copy `grails-forge/grails-forge-web-netty/aws/` from the matching maintenance branch, then from `grails-forge` run: + +```bash +./gradlew grails-forge-web-netty:awsElasticBeanstalk +``` + +The bundle is `grails-forge-web-netty/build/distributions/grails-forge-web-netty-aws.zip`. See [AWS Elastic Beanstalk Deployment Runbook](grails-forge/docs/aws-elastic-beanstalk.md). Review Comment: This section says a historical tag deployment is "packaged locally, then uploaded to Elastic Beanstalk", but the steps shown only build the ZIP and don’t describe an upload/deploy path. Consider rephrasing this as a note about how to build the ZIP for older tags (and that it’s the same bundle the GitHub Actions workflow uploads) to avoid implying missing manual deploy steps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
