Copilot commented on code in PR #16263:
URL: https://github.com/apache/grails-core/pull/16263#discussion_r3885161366
##########
.github/workflows/forge-deploy-aws.yml:
##########
@@ -163,9 +163,18 @@ jobs:
wait_for_ready_green() {
local operation="$1"
local expected_version="$2"
- local status health current_version attempt
+ local status health current_version attempt event
+ local start_iso
Review Comment:
`wait_for_ready_green` always sets `start_iso` when the function begins.
Since the function is called after `update-environment`, any ERROR event
emitted between the update call and the function start can be missed, which
undermines the intended "fail fast on EB errors" behavior. Accept an optional
start timestamp so the caller can set it before initiating the deployment
operation.
This issue also appears on line 205 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
