jamesfredley opened a new pull request, #16268: URL: https://github.com/apache/grails-core/pull/16268
## Summary - Remove the accidental `List`-returning `AbstractCriteriaBuilder.list(Closure)` overload that conflicts with the established reactive criteria API. - Restore per-`RxDatastoreClient` tenant bindings with nested-scope cleanup, client isolation, and fail-closed fallback to the core tenant holder. - Port `CountByFinder` to the current dynamic-finder query API and verify count projections through public finder invocation. ## Validation - Full `:grails-datamapping-core:test` and `:grails-datamapping-rx:test` suites. - `:grails-datamapping-rx:codeStyle` and repository-wide CodeNarc, Checkstyle, PMD, and SpotBugs aggregation with no violations. - Downstream MongoDB, Neo4j, and Hibernate 7 core compilation. - External public-surface driver confirming reactive `CriteriaBuilder.list(Closure)` emits the expected list. - Independent goal, code-quality, security, hands-on QA, context, Oracle, and Codex reviews. ## Root-wide test note The full repository aggregate run reached 3,570 integration tests and reported three unrelated example failures: an asynchronous SiteMesh request-recycling failure, a missing Docker environment for one Hibernate/Geb example, and a Selenium page-load timeout in the Spring Security ACL example. It also encountered the existing `grails-spring-security-ui:copyTemplates` duplicate-entry failure. All affected core and RX suites are green. @borinquenkid, please review this compatibility repair. It should be merged forward into `9.0.x` after landing on `8.1.x`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
