The GitHub Actions job "CI" on grails-core.git/perf/request-path-8.0.x has succeeded. Run started by GitHub user codeconsole (triggered by codeconsole).
Head commit for run: 7ea7ab40c17b87b80a355ddc67211fd2eeaa1cd7 / Scott Murphy Heiberg <[email protected]> test: prove the method override by what it routes, not by what request.method says FileUploadSpec asserted that a multipart POST carrying _method=PUT left request.method reporting PUT. That was written when the filter was registered by default, and the filter wraps the request before it is bound, so it did. With the override resolved in the dispatcher instead, POST is the honest answer: it is the method on the wire, the method Spring Security saw, and the method the access log records. Making request.method say otherwise would put back exactly the kind of divergence between what an application sees and what the infrastructure saw that moving the override out of the filter chain removes. The action was reachable by any method, so request.method was the only thing the test could observe and the override was not visibly doing anything. Declaring allowedMethods PUT on it gives the test something real to assert: the request reaches the action only because the override was resolved, since allowedMethods reads the effective method. A second case sends the same upload without the parameter and expects 405, which is what makes the first assertion mean something. Report URL: https://github.com/apache/grails-core/actions/runs/33339234623 With regards, GitHub Actions via GitBox
