Copilot commented on code in PR #16298:
URL: https://github.com/apache/grails-core/pull/16298#discussion_r3919038641
##########
.github/workflows/gradle.yml:
##########
@@ -1012,9 +1012,8 @@ jobs:
uses:
testlens-app/setup-testlens@3f82d2dc6cd5c03f02ce5f7885a21195d85f8d14 # v1.9.3
- name: "📤 Publish Grails-Core Snapshot Artifacts"
# This Java 21 publish excludes the Micronaut 5 / JVM 25 island
automatically -
- # settings.gradle prunes it on a sub-25 JDK. The island artifacts
(grails-micronaut,
- # grails-micronaut-bom) are published by the parallel publishMicronaut
job below,
- # which runs on JDK 25.
+ # settings.gradle prunes it because this branch uses Groovy 6 while
the island pins
+ # Groovy 5.
Review Comment:
The updated comment attributes Micronaut-island pruning solely to the Groovy
major mismatch, but settings.gradle actually prunes the island based on both
JDK (<25) and Groovy major (!= 5). For long-term maintainability (and
consistency with other comments in this workflow), consider wording this
comment to reflect the full settings.gradle condition and only call out Groovy
6 as the reason on this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
