The GitHub Actions job "SiteMesh 2 Compatibility" on 
grails-core.git/fix/scaffold-count-type-8.0.x has failed.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
140f173f800de56d62ec0e5a9f1813d9845e9f59 / Scott Murphy Heiberg 
<[email protected]>
Simplify the welcome page sort closures

The previous commit made the page compile statically, but did it by
annotating the comparators rather than by restoring the element types,
which left three closures heavier than the rest of the page. Every other
sort here reads `sort { it.something }`.

Derive the domain grouping key as a String instead of from an untyped
local, and the sort needs no annotation at all. Declare the listener maps
as Map<String, String>, and the toString() calls guarding the comparison
are unnecessary. Sort the plugin rows by a single key so the cast appears
once rather than on both sides.

The plugin comparison still needs its cast and its qualified name: the
rows are heterogeneous maps, so the value is Object, and GSP always
imports grails.plugins.metadata.GrailsPlugin.

Do not name a closure parameter `it`. It compiles ahead of time, but the
page is parsed again at runtime when reloading is on, and that path
rejects it with "The current parameter list already contains a parameter
of the name it".

Report URL: https://github.com/apache/grails-core/actions/runs/34168744753

With regards,
GitHub Actions via GitBox

Reply via email to