The GitHub Actions job "SiteMesh 2 Compatibility" on 
grails-core.git/fix/scaffold-count-type-8.0.x has succeeded.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
8855b8834053d20d6b8759e5d066a58b5d318be8 / Scott Murphy Heiberg 
<[email protected]>
Declare the scaffolded count model field as Number

Changing the field to Long fixed views generated alongside the generated
service, which declares Long count(), but broke dynamic scaffolding. A
controller using `static scaffold = X` is backed by RestfulController,
whose countResources() returns Integer, so those pages then failed the
other way:

    Model field 'authorCount' is declared as java.lang.Long
    but the model supplied an instance of java.lang.Integer

One template serves both paths, so it cannot name either concrete type.
Number accepts what each supplies, and the pagination comparison still
compiles statically against it.

Covered by a test that renders the field from Integer, Long, Short and
BigInteger, so neither supplier can regress the other again.

Report URL: https://github.com/apache/grails-core/actions/runs/34173330613

With regards,
GitHub Actions via GitBox

Reply via email to