The GitHub Actions job "CI" on grails-core.git/fix/16287-devtools-review has 
failed.
Run started by GitHub user jdaugherty (triggered by jdaugherty).

Head commit for run:
29abfeedd645985f7735ff9fa7eac7b2d1a874fa / James Daugherty 
<[email protected]>
Resolve the DevTools restart loader through the parent chain

Under a DevTools restart the thread context class loader is not always the
RestartClassLoader itself. A servlet container swaps its web application
loader in during context start (Tomcat's TomcatEmbeddedWebappClassLoader),
and that loader delegates to the RestartClassLoader as its parent. A check
that matched only the loader's own type fell back to the base loader in
exactly that window, which is how a Hibernate 5 SessionFactory built while
Tomcat was starting ended up with base-loader entity classes (#16287). Walk
the parent chain instead, and keep a fallback that already sees the restart
loader.

Hibernate 5 now mirrors Hibernate 7: the connection source is always the
DataSource of record, and the application context, when present, supplies
the resource resolver and class loader. That removes the duplicated
bean-name derivation from the factory, and setApplicationContext no longer
replaces a DataSource that setDataSourceConnectionSource configured.

Drop the never-released resolve() alias and the guide paragraph describing
the internal wiring, and cover the container-loader case in the specs.

Report URL: https://github.com/apache/grails-core/actions/runs/34261625861

With regards,
GitHub Actions via GitBox

Reply via email to