codeconsole opened a new pull request, #16327:
URL: https://github.com/apache/grails-core/pull/16327
A generated compiler script assigned as a plain file, with its producer
added only to `compileGroovy.dependsOn`, can be read before it exists. The
earlier producer test only inspected a dry-run graph and had no Groovy source
to compile.
Replace that check with an execution fixture that compiles and runs source
requiring both Grails imports and the generated user script. Cover a clean
build, unchanged up-to-date behavior, changed script content, the legacy wiring
failure followed by successful provider wiring, and an unrelated compilation
prerequisite that would form a cycle if the generator inherited all compilation
dependencies.
Document the `configurationScriptFile.set(producer.flatMap { it.outputFile
})` migration in the Grails 8 upgrade guide. This follow-up uses the existing
provider support; it does not add inferred dependencies or restore
execution-time compiler-option assignment.
Follow-up to #16114 and [the task-ordering
discussion](https://github.com/apache/grails-core/pull/16114#issuecomment-5516571268).
The plain-file failure is made deterministic by requesting script preparation
before the verification task; the provider-wired version succeeds with the same
requested task order.
Validation:
- From `grails-gradle/`: `./gradlew :grails-gradle-plugins:test
:grails-gradle-plugins:codeStyle
:grails-gradle-plugins:validateDependencyVersions --no-daemon --offline
--max-workers=2 -PmaxTestParallel=2` — passed; 267 tests, no failures or skips,
including all 12 compiler configuration cases.
- `./gradlew :grails-doc:publishGuide -x aggregateGroovydoc --offline
--no-daemon --max-workers=2` — passed; the new section appears in the generated
upgrade guide.
- `git diff --check` — passed.
- Required root gate attempted: `./gradlew clean aggregateViolations
:grails-test-report:check --continue --no-daemon --max-workers=6
-PmaxTestParallel=3`. All four violation reports contain `No violations
found!`. The full test run was interrupted after PostgreSQL/MongoDB container
startup failures and MongoDB reporting `No space left on device`; it did not
pass or complete. These failures occurred in unchanged database modules.
Aggregate Markdown report generation from the interrupted run failed on an
incomplete MongoDB test XML file, so full-suite coverage remains unverified. No
shared Docker data was removed.
[Follow-up on the original
PR](https://github.com/apache/grails-core/pull/16114#issuecomment-5591096750)
acknowledges the concern and asks for the affected build's actual task wiring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
