codeconsole commented on PR #16323: URL: https://github.com/apache/grails-core/pull/16323#issuecomment-5650420019
All three fixed in `c8f5c8f9`. 1. Duplicated clause removed. 2. Now `// or Number, to accept either width`. 3. `gsonHal.adoc` — `bookCount` is `Long` and the call passes `offset, max`. Confirmed against the signature: `paginate(Object, Long total, Long offset, Integer max, String sort, String order)`. Good catch that it only compiles today because `Integer` widens into the new `Long offset` — it would have kept producing links with the two exchanged. One you didn't mention, same file: the `hal.links()` example at line ~308 also declared `Integer bookCount`, and `links(Map, Object, Long total)` changed in this PR too, so I moved that one to `Long` as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
