codeconsole commented on PR #16282: URL: https://github.com/apache/grails-core/pull/16282#issuecomment-5653947891
All three taken. **Blocking, unused import (`534956d3f5`).** Dropped. Confirmed from the job log that CodeNarc in `grails-data-mongodb/bson` was the only style failure, and `:grails-data-mongodb-bson:codenarcMain` + `checkstyleMain` are clean locally, as are the other two changed modules. **Low, unit pin for the exact-class rule (`bc0b7950e6`).** Added, as the `where:` form over all three classes plus the subclass exclusion. `Mock(Session)` is enough exactly as you said — the empty key set short-circuits before the session is consulted. Verified both directions rather than just that they pass: the three parameterised cases go red if the gate stops accepting `PersistentCollection`, and the subclass case goes red if the exact-class check is relaxed to `instanceof PersistentCollection` — which is the change that regressed Neo4j in the first push, so it now has a unit-level guard that does not need a container. **Nit, contradicting paragraphs (`bc0b7950e6`).** Led the sentence with the scope, and added the other half explicitly, since the asymmetry is the part worth stating: re-initialising a to-many on its own entity is tracked; only one borrowed from another entity is stored as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
