Copilot commented on code in PR #16337: URL: https://github.com/apache/grails-core/pull/16337#discussion_r4011217802
########## grails-forge/grails-forge-core/src/main/java/org/grails/forge/ForgeContexts.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.forge; + +import org.springframework.context.annotation.AnnotationConfigApplicationContext; +import org.springframework.core.env.ConfigurableEnvironment; +import org.springframework.core.env.MapPropertySource; +import org.springframework.core.env.StandardEnvironment; + +import java.util.Map; + +public final class ForgeContexts { + + private ForgeContexts() { + } + + public static AnnotationConfigApplicationContext create() { + return create(Map.of()); + } + + public static AnnotationConfigApplicationContext create(Map<String, Object> configuration) { + AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(); + if (configuration != null && !configuration.isEmpty()) { + ConfigurableEnvironment environment = new StandardEnvironment(); + environment.getPropertySources().addFirst(new MapPropertySource("forge-test", configuration)); + context.setEnvironment(environment); + } Review Comment: The map is only added as an `Environment` property source, but this plain `AnnotationConfigApplicationContext` never registers Spring Boot's configuration-properties binder. Therefore `GrailsForgeConfiguration` (the scanned `@ConfigurationProperties` bean) keeps its defaults and calls such as `ForgeContexts.create(['grails.forge.redirect-url': '...'])` silently have no effect; bind the properties explicitly or register the binding post-processor for this standalone context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
