codeconsole commented on PR #16338: URL: https://github.com/apache/grails-core/pull/16338#issuecomment-5684704170
Addressed the Review Findings in b4aa3c6622. - The bounded in-process shutdown regression now runs ten times on separate ports. The Java fixture comment and PR description now describe both reproductions as timing-dependent. - Added `onlyNeo4jTests` to the Spring Security test configuration. - Documented that `RunningEmbeddedMongo.stop()` must do nothing when the server is already stopped, and strengthened the stopped-state assertions for both backends. - Enabled `slf4j-simple` for the embedded module's tests so the child JVM log includes initializer diagnostics. - Clarified the Redis settings and runtime dependencies removed with `test-config.gradle`, and corrected the cleanup reference to `EmbeddedMongoInitializerSpec` in the PR description and follow-up commit message. Validation completed before the commit: - `:grails-data-mongodb-embedded:test`: 60 tests passed, zero failures or skips. - `:grails-data-mongodb-embedded:codeStyle` and `:grails-data-mongodb-embedded:validateDependencyVersions`: passed. - Verified all 27 Spring Security test tasks across 12 modules are excluded with `-PonlyNeo4jTests` and remain enabled with `-PonlySpringSecurityTests`; the Neo4j plugin's test task remains enabled under its flag. The full repository commit gate did not complete: its first run lost the Gradle daemon, and the isolated retry was stopped at the maintainer's request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
