matrei commented on PR #16040: URL: https://github.com/apache/grails-core/pull/16040#issuecomment-5703184725
> @matrei we merged #16149 - is this PR even needed still? I think we can just close it, yes? @jdaugherty No, it is still needed. #16149 changed how an *oversized* upload fails, not where the limits come from. On `8.0.x` today `ControllersAutoConfiguration` still builds its own `MultipartConfigElement` from `grails.controllers.upload.*`, with the 128000-byte defaults, and #15644 (adopt `spring.servlet.multipart`) is still open. That is exactly what this PR does, and nothing in #16149 overlaps with it. It does need a rebase though. Two files conflict, and a few things #16149 added now reference the old properties and have to move over with it: - `ControllersAutoConfiguration.java` — the `dispatcherServlet` bean now takes an `Environment` for the hidden-method resolution, and the `multipartConfigElement` bean this PR removes sits right next to it. - `THREAT_MODEL.md` / `threat-model.yaml` — the upload-limit row now describes `ControllersAutoConfiguration` overriding Boot's `MultipartProperties`; it should describe Boot's 1 MB / 10 MB defaults instead. - Upgrade guide §53.1 (oversized uploads) and its Undertow note name `grails.controllers.upload.maxFileSize` / `maxRequestSize` and the 128000-byte defaults. - `FileUploadSpec` on `8.0.x` gained an "upload exceeding the configured limit" test that posts 200000 bytes against the 128000 default. With this PR's app1 config (`spring.servlet.multipart.maxRequestSize: 3KB`) it still trips the limit, but the `given:` label should be updated. @gsartori are you able to rebase, or would you like me to push the rebase onto your branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
