codeconsole commented on PR #16230: URL: https://github.com/apache/grails-core/pull/16230#issuecomment-5703956337
Thanks for the detailed review and probes, @matrei. Addressed the behavioral and documentation findings in five focused commits: - H1: the default event bus now uses the promise factory's exposed executor, while retaining support for factories that implement `Executor`. Spring bean introspection keeps events-core independent of the optional async module. A regression test verifies asynchronous delivery on the shared worker. - H2, M2, L1: only completion/execution wrappers are unwrapped; caused application exceptions retain their identity. Single and aggregate error callbacks agree, direct/chained/timed `get()` calls retain `ExecutionException`, and MVC receives the original failure. - H3, H4: resolve `applicationTaskExecutor` by name, otherwise use the named Grails fallback with eight core threads. Tests cover additional executors/schedulers and two mutually dependent tasks. - M1: default standalone `WebPromises` adapts the same Spring request decorator without requiring plugin initialization. Tests no longer pre-wire propagation and cover request parameters and response writing on a worker. - L2, L3: both request entry points honor `spring.mvc.async.request-timeout`, falling back to the container default. Completion is also recorded on the request because Spring removes its async manager on completion; subsequent task submission is rejected before executing work. - M3, L4: added the 8.0 migration guidance, Servlet API/trait deprecation notices, and documentation of the global decorator's effect on other Boot-managed executors. - L5: left history unsquashed per the contributor's explicit instruction to retain focused commits. The cancelling historical commits remain unchanged. Validation: Java 21 async-core, async web, events-core, and URL-mapping suites: 358 tests, one existing skip, no failures. Java 25 changed-module suites: 99 tests, one existing skip, no failures. The Java 21 async HTTP error-handling functional test also passes, as do affected-module style and dependency-version checks. No full-repository clean/aggregate sweep was run; verification used bounded workers and test parallelism. Commits: f269620071, c8c9a0b1b2, b8796c25fd, f7da7dee19, a29efe7561. The PR summary and LOC table have been refreshed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
