jdaugherty commented on PR #16361:
URL: https://github.com/apache/grails-core/pull/16361#issuecomment-5764086206
@matrei Looks like the check style build is legitimately broken, here is my
AI output:
PR #16361 bumps checkstyleVersion=13.7.0 → 13.11.0 in gradle.properties:63.
The full error (Gradle truncates it in CI; I reproduced it locally with
--stacktrace):
cannot initialize module TreeWalker - cannot initialize module JavadocStyle
> Unable to instantiate 'JavadocStyle' class, it is also not possible to
instantiate it as
.JavadocStyle, JavadocStyleCheck, .JavadocStyleCheck.
I diffed the check classes in the two jars — JavadocStyle is the only check
removed between 13.7.0 and 13.11.0:
$ comm -23 checks-13.7.0.txt checks-13.11.0.txt
JavadocStyle
Why only Forge fails: grails-forge/gradle.properties:56 points Checkstyle at
grails-forge/config/checkstyle/checkstyle.xml, a legacy Micronaut-derived
config separate from the repo-wide one in
build-logic/.../grails-code-style/checkstyle/checkstyle.xml. The shared config
never used JavadocStyle, so "Core Projects" passed. The config fails to load,
which is why the failure is an invoker error rather than a violation report —
and why the uploaded forge-reports artifact is empty of useful detail.
Fix — delete the module at
grails-forge/config/checkstyle/checkstyle.xml:119-121:
<module name="JavadocStyle">
<property name="checkFirstSentence" value="false"/>
</module>
Nothing is lost that the config was actually enforcing broadly: with
checkFirstSentence=false and checkEmptyJavadoc defaulting off, it was only
doing Javadoc HTML validation, and the shared repo config doesn't run that
check at all.
Verified locally: with that block removed, ./gradlew codeStyle
-PcheckstyleVersion=13.11.0 in grails-forge is BUILD SUCCESSFUL across all
modules — so no follow-on violations from the version bump either. I've
reverted my working tree back to clean (you're on feat/gorm-lock-latest; the
fix belongs on matrei's deps/dependency-updates-2026-09).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
