codeconsole commented on PR #16369:
URL: https://github.com/apache/grails-core/pull/16369#issuecomment-5779151193
@matrei thanks. Addressed in 2d8770e5cd:
- **[P3] Upgrade note:** section 72 now says the save threw only with
nothing else open, and that with a default-connection session further out, from
the open-session-in-view interceptor or an outer `@Transactional`, it wrote the
instance to the default database silently. Your cross-datasource copy is in it
as the case to look for.
- **[P3] `@Transactional(connection)`:** the guide's paragraph, and both
Hibernate guides', now say the routing comes from the namespace's own
`withTransaction`, `withNewTransaction`, `withSession` and `withNewSession`,
and that a method annotated `@Transactional(connection = 'auditing')` opens the
same transaction without it.
- **The scope stops at the class:** "Other domain classes are not affected"
is added in the guide, both Hibernate guides and the MongoDB and Neo4j pages.
- **Coverage:** `Player.one.withSession { Player.count() }` in
`MultipleDataSourceSpec`, and `ScopedCompany.test2.withStatelessSession {
ScopedCompany.count() }` in the MongoDB `MultipleConnectionsSpec`, which is a
`StatelessDatastore`. Both fail without this change.
The branch also has #16368's review changes merged in (9e0312eb15). With a
scope now resolving as the named connection does, the tweak this branch made so
that `scopedConnection` reported a `default` scope as none is no longer needed,
and is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
