codeconsole commented on PR #16368:
URL: https://github.com/apache/grails-core/pull/16368#issuecomment-5779150835
@matrei thanks. Addressed in b34471f68c and 5e5b35a599:
- **[P2]** Taken as you suggested. A lookup that names no connection now
takes the scope as its qualifier and goes through the ordinary resolution, and
the three `getDirect` short-circuits are gone, so a scope resolves exactly as
naming the connection does. `ConnectionScopeMultiTenancySpec` reproduces your
probe on a DATABASE-mode `SimpleMapDatastore`: with tenant `foo` bound, a
`default` scope now counts `foo`'s two books, as `Book.'default'.count()` does,
where it counted the default store's zero before.
- **[P3]** Precedence left as it is. The `withConnectionScope` javadoc and
both `withConnection` pages now say that for a multi-tenant class the block's
connection takes precedence over the current tenant, as a connection named
explicitly does. The same spec records it: `Tenants.withId('foo')` inside a
`bar` scope reads `bar`, like `Tenants.withId('foo') { Book.bar.count() }`.
- **Per thread:** both pages now say "on the thread that calls
`withConnection`".
- **Comment wording:** fixed.
- **Three fixes, one issue:** the Neo4j 8.0.x release notes now quote both
errors, `The event loop thread may not be smaller than 1, but was 0` and
`Cannot flush write operations without an active transaction!`, so a search for
either finds the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
