jdaugherty commented on PR #37:
URL:
https://github.com/apache/grails-gradle-publish/pull/37#issuecomment-5779149426
Pushed 09472a7 with the two items left open above.
**Jar helpers** — `findJarFileEntry` moved to `GradleSpecification`
alongside the new `readJarFileEntry`. It was duplicated verbatim in both specs,
and only one of the two could read entry content.
**Groovydoc destination** — now read through a provider rather than resolved
when the jar is configured.
One correction on that second one, since the note above implied a live bug:
it isn't. The value is read when `javadocJar` is realized, which is *after*
`groovydoc` has been realized and all of its configuration applied — so the jar
already followed a retargeted `destinationDir`. Checked both ways it would
plausibly be set:
- from the build script — `tasks.named('groovydoc') { destinationDir =
file("$buildDir/docs/api") }`
- from a later `afterEvaluate`, which is the case the note actually described
In both, groovydoc wrote to `build/docs/api` and the jar came out with its
full 23 entries. So this commit is hardening against a change in realization
order, not a fix for an observed failure. Worth having, but nobody was hitting
it.
Test suite is unchanged at 54 tests, 0 failures, 6 pre-existing
`@PendingFeature` skips; `rat` passes; configuration cache still stores and
reuses cleanly with a byte-identical jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
