codeconsole commented on code in PR #16375:
URL: https://github.com/apache/grails-core/pull/16375#discussion_r4073394709
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/lang/groovy/application.rocker.raw:
##########
@@ -72,7 +72,9 @@ class Application extends GrailsAutoConfiguration {
bean('filterChain', SecurityFilterChain) { HttpSecurity http ->
http
.authorizeHttpRequests {
- it.requestMatchers('/', '/index', '/index.gsp', '/error',
'/assets/**').permitAll()
+ // The browser fetches the favicon on its own, also for
the login and logout pages;
Review Comment:
is the inline comment needed? or is it obvious?
##########
grails-test-examples/scaffolding/grails-app/init/com/example/Application.groovy:
##########
@@ -23,16 +23,32 @@ import grails.boot.config.GrailsAutoConfiguration
import groovy.transform.CompileStatic
import org.grails.datastore.gorm.timestamp.AuditorAware
-import org.springframework.context.annotation.Bean
+import org.springframework.security.config.Customizer
+import org.springframework.security.config.annotation.web.builders.HttpSecurity
+import org.springframework.security.web.SecurityFilterChain
@CompileStatic
class Application extends GrailsAutoConfiguration {
static void main(String[] args) {
GrailsApp.run(Application, args)
}
- @Bean
- AuditorAware<String> auditorAware() {
- return new SpringSecurityAuditorAware()
+ def beans = {
+ bean('auditorAware', AuditorAware, SpringSecurityAuditorAware)
+
+ // Spring Boot's default chain, with the static resources the browser
fetches on its own
Review Comment:
Is this 5 LOC inline comment needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
