codeconsole commented on PR #16377: URL: https://github.com/apache/grails-core/pull/16377#issuecomment-5790180888
@matrei thanks for the thorough review. Addressed: - **Triple-quoted literal regression:** b83626345d delegates both expression and quoted-value boundaries to `GroovyPageExpressionParser` as you proposed (`String` signature, `-1` → end of source); `skipExpression`/`skipStringLiteral` are gone. `'''it's fine'''` and `"""say "hi" now"""` cases are in both specs; the engine-level one runs under strict and fails against the previous scan. - **Long-page test not checking the name:** 2a99acb013 adds `compileStaticConfig.strict`. With the scan stubbed to find nothing, it now fails with the name undeclared. - **Stack size hint:** agreed; it can only under-prove, and it's honoured on Linux x64 where this was reported. - Updated the description: the "same names as before" line no longer overclaims. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
