codecov[bot] commented on PR #16411: URL: https://github.com/apache/grails-core/pull/16411#issuecomment-5844272480
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16411?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `85.03937%` with `38 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.9571%. Comparing base ([`0dab8a7`](https://app.codecov.io/gh/apache/grails-core/commit/0dab8a726376f819375a95f2a90c70ad6d19d00a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4d60dba`](https://app.codecov.io/gh/apache/grails-core/commit/4d60dba3d56903439a3bbf2c9d70c5d9bfdff639?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16411?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...y/grails/plugin/json/view/JsonViewGenerator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-views-gson%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fplugin%2Fjson%2Fview%2FJsonViewGenerator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXZpZXdzLWdzb24vc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9wbHVnaW4vanNvbi92aWV3L0pzb25WaWV3R2VuZXJhdG9yLmdyb292eQ==) | 84.2105% | [2 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...converters/marshaller/json/DurationMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FDurationMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0R1cmF0aW9uTWFyc2hhbGxlci5qYXZh) | 71.4286% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...onverters/marshaller/json/LocalTimeMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FLocalTimeMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0xvY2FsVGltZU1hcnNoYWxsZXIuamF2YQ==) | 75.0000% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...converters/marshaller/json/MonthDayMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FMonthDayMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL01vbnRoRGF5TWFyc2hhbGxlci5qYXZh) | 71.4286% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...eb/converters/marshaller/json/MonthMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FMonthMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL01vbnRoTWFyc2hhbGxlci5qYXZh) | 71.4286% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...nverters/marshaller/json/OffsetTimeMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FOffsetTimeMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL09mZnNldFRpbWVNYXJzaGFsbGVyLmphdmE=) | 71.4286% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...b/converters/marshaller/json/PeriodMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FPeriodMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL1BlcmlvZE1hcnNoYWxsZXIuamF2YQ==) | 71.4286% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../converters/marshaller/json/SqlTimeMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FSqlTimeMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL1NxbFRpbWVNYXJzaGFsbGVyLmphdmE=) | 71.4286% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...converters/marshaller/json/TimeZoneMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FTimeZoneMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL1RpbWVab25lTWFyc2hhbGxlci5qYXZh) | 71.4286% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...arshaller/json/XMLGregorianCalendarMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FXMLGregorianCalendarMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL1hNTEdyZWdvcmlhbkNhbGVuZGFyTWFyc2hhbGxlci5qYXZh) | 75.0000% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [8 more](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## 8.0.x #16411 +/- ## ================================================== + Coverage 57.8138% 57.9571% +0.1433% - Complexity 22800 22936 +136 ================================================== Files 2135 2160 +25 Lines 104456 104693 +237 Branches 18747 18769 +22 ================================================== + Hits 60390 60677 +287 + Misses 35736 35679 -57 - Partials 8330 8337 +7 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16411?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...figuration/ConvertersConfigurationInitializer.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FConvertersConfigurationInitializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9Db252ZXJ0ZXJzQ29uZmlndXJhdGlvbkluaXRpYWxpemVyLmphdmE=) | `89.9281% <100.0000%> (+2.6265%)` | :arrow_up: | | [...converters/marshaller/json/CalendarMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FCalendarMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0NhbGVuZGFyTWFyc2hhbGxlci5qYXZh) | `86.6667% <100.0000%> (ø)` | | | [...web/converters/marshaller/json/DateMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FDateMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0RhdGVNYXJzaGFsbGVyLmphdmE=) | `86.6667% <100.0000%> (ø)` | | | [.../web/converters/marshaller/json/MapMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FMapMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL01hcE1hcnNoYWxsZXIuamF2YQ==) | `92.3077% <100.0000%> (ø)` | | | [.../web/converters/marshaller/xml/DateMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fxml%2FDateMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci94bWwvRGF0ZU1hcnNoYWxsZXIuamF2YQ==) | `90.0000% <100.0000%> (+1.7647%)` | :arrow_up: | | [...ing/converters/DefaultConvertersConfiguration.java](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-databinding%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatabinding%2Fconverters%2FDefaultConvertersConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFiaW5kaW5nL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFiaW5kaW5nL2NvbnZlcnRlcnMvRGVmYXVsdENvbnZlcnRlcnNDb25maWd1cmF0aW9uLmphdmE=) | `100.0000% <100.0000%> (ø)` | | | [...lugin/json/converters/DurationJsonConverter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-views-gson%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fplugin%2Fjson%2Fconverters%2FDurationJsonConverter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXZpZXdzLWdzb24vc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9wbHVnaW4vanNvbi9jb252ZXJ0ZXJzL0R1cmF0aW9uSnNvbkNvbnZlcnRlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...lugin/json/converters/MonthDayJsonConverter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-views-gson%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fplugin%2Fjson%2Fconverters%2FMonthDayJsonConverter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXZpZXdzLWdzb24vc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9wbHVnaW4vanNvbi9jb252ZXJ0ZXJzL01vbnRoRGF5SnNvbkNvbnZlcnRlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...s/plugin/json/converters/MonthJsonConverter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-views-gson%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fplugin%2Fjson%2Fconverters%2FMonthJsonConverter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXZpZXdzLWdzb24vc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9wbHVnaW4vanNvbi9jb252ZXJ0ZXJzL01vbnRoSnNvbkNvbnZlcnRlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...gin/json/converters/OffsetTimeJsonConverter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree&filepath=grails-views-gson%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fplugin%2Fjson%2Fconverters%2FOffsetTimeJsonConverter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXZpZXdzLWdzb24vc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9wbHVnaW4vanNvbi9jb252ZXJ0ZXJzL09mZnNldFRpbWVKc29uQ29udmVydGVyLmdyb292eQ==) | `100.0000% <100.0000%> (+50.0000%)` | :arrow_up: | | ... and [27 more](https://app.codecov.io/gh/apache/grails-core/pull/16411?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16411/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
