jdaugherty commented on PR #16416: URL: https://github.com/apache/grails-core/pull/16416#issuecomment-5873213681
@matrei, addressed the requested change and the remaining feedback in 0a40d94fa183df1d529e3de28613060616fc29c8. - **Late configuration roles:** `withDependencies` now rechecks `canBeDeclared` before adding the platform. The regression fixture creates a non-declarable configuration in a later `afterEvaluate` callback and resolves it under `--warning-mode=fail`. It reproduced the reported exception before the fix and now passes. A companion assertion verifies that a late-created declarable configuration still receives its default dependency and the BOM. - **JaCoCo tool classpaths:** agreed; both `jacocoAgent` and `jacocoAnt` are now excluded from automatic application-platform injection, like the other tool configurations. The fixture verifies that their defaults resolve without the BOM and explicitly asserts both BOM-presence diagnostics are false. The `profile` and custom `defaultDependencies` coverage remains in place. - **Property-override detection:** added a three-case resolution test covering automatic detection enabled, disabled without explicit registration, and disabled with an explicitly registered BOM. Disabling detection leaves the platform in place but does not apply the property override unless the BOM is explicitly registered. - **Documentation:** the upgrade notes now explain that `dependencies` / `allDependencies` do not expose the auto-applied BOM until observation, and direct build logic to `incoming.dependencies` or the resolution result. Both guide sections now use “observed” and describe the tool-classpath exclusions. Verification on Gradle 9.8.0 / JDK 21: | Check | Result | | --- | --- | | Full `grails-gradle-plugins` suite | 313 tests across 44 suites; zero failures or skips | | Plugin dependency validation and aggregate violation reports | Clean | | Root aggregate tests | 21,311 reported; zero failures/errors; 445 skipped | | Root aggregate violation reports | All four summaries clean | | Apache RAT | Zero unknown licenses after removing two ignored Neo4j runtime files generated by the tests | There are no inline review threads on this PR to resolve, so this response covers the feedback in the review body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
