matrei opened a new pull request, #16435:
URL: https://github.com/apache/grails-core/pull/16435

   ## Summary
   
   `PerTestRecordingSpec` checks that each per-test recording is larger than 5 
KB, so that a near-blank capture is reported as such instead of failing the 
byte-difference check. The first setup test only loads the home page and 
finishes. A recording container that was just restarted may then have captured 
only its first frames, which failed the check in the Groovy Snapshot Canary 
Build of #16093:
   
   ```
   firstRecording.length() > MIN_MEANINGFUL_RECORDING_BYTES
   |              |        | |
   |              3370     | 5000
   |                       false
   ```
   
   The second setup test already pauses for 500 ms, and its recording passed. 
The first setup test now pauses as well.
   
   ## Testing
   
   `PerTestRecordingSpec` passes in three local runs. The recordings are 74-76 
KB for the first test and 65-68 KB for the second. Local runs were above the 
floor before the change too, so they show that the spec still passes, not the 
slow-runner case the pause is for.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to