jdaugherty commented on PR #16203: URL: https://github.com/apache/grails-core/pull/16203#issuecomment-5913668659
Rebased onto `8.1.x` (the #16201 commit was already merged, so it was dropped) and dropped the commit **"Simplify DeleteEntityDataFetcher.get() to build the response per branch"**. Moving `createResponse` inside the `try` changed behavior: if the (user-replaceable) `GraphQLDeleteResponseHandler` throws while building the success response, the fetcher now catches that and returns `createResponse(env, false, e)`, so the client is told the delete failed even though the row has already been removed. Previously the handler exception propagated as a GraphQL field error. Verified with a probe spec using a handler that throws on the success path: 8.1.x → exception propagates; PR head → `[success: false, error: ...]` with zero rows left. The original structure is kept and a comment now documents why the response must be built outside the `try`. The remaining fetcher/interceptor commits are unchanged. `:grails-data-graphql-core:test` and `codeStyle` pass on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
