jdaugherty commented on PR #15652: URL: https://github.com/apache/grails-core/pull/15652#issuecomment-5916331046
Revisiting this now that the CLI split has landed on `8.0.x`. **What the split changed.** Of the three blockers I listed in May, the first (the shell needing the build classpath) is gone: commands now live in the `-cli` companion artifacts and never reach the application classpath. The other two still stand: plugins such as hibernate and dbmigration still ship their build-side code in the same artifact, and `BuildSettings` still exists under `grails-gradle/model`. **The leak this PR describes still exists.** Every application BOM on `8.0.x` (base, default, hibernate5, hibernate7, neo4j) still iterates all of `gradleBomDependencies` into its constraints, so `asciidoctor-gradle-jvm`, `asset-pipeline-gradle`, `grails-publish`, and `spring-boot-gradle-plugin` are still published as managed versions in the app BOMs. Nothing in the application tree references them; only `build-logic`, `grails-gradle`, and `grails-forge` buildSrc do. **The headline example no longer holds.** `javaparser-core` is now a real runtime `api` dependency of `grails-data-graphql` core and plugin, so it must stay managed in the application BOM. The drift has also gone quiet: the last bump was 3.28.2 on 2026-06-02, which matches what Groovy 5.1.3's groovydoc and console modules pull. If it drifts again, the fix is moving that key into the application versions map rather than dropping it. **The diff itself is stale.** - Conflicts with `8.0.x` in `grails-bom/hibernate7/build.gradle`. - Patches `grails-bom/micronaut`, which moved to apache/grails-micronaut in September. - Predates the hibernate7 and neo4j BOMs, which would keep leaking. - #16428 added `validateBomProperties` since then, so any rework needs that check run. My suggestion is to close this draft as superseded and open a fresh, smaller PR against `8.0.x` that skips only the four Gradle plugin coordinates in the five app BOMs, keeps `javaparser-core` managed, and leaves `spring-boot-cli`, `spring-boot-loader-tools`, and `asciidoctorj` for a separate decision as you already suggested. @jamesfredley does that match your read? If so I'll close this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
