bito-code-review[bot] commented on PR #16458: URL: https://github.com/apache/grails-core/pull/16458#issuecomment-5929182290
<!-- Bito Reply --> The change from `HashSet` to `LinkedHashSet` for `dataSourceNames` ensures that the order of data sources is preserved during initialization. This is appropriate because the order of connection sources can be significant in Grails/GORM configuration, and `LinkedHashSet` provides predictable iteration order while maintaining the uniqueness guarantees of a `Set`. **grails-data-hibernate5/grails-plugin/src/main/groovy/grails/orm/bootstrap/HibernateDatastoreSpringInitializer.groovy** ``` - Set<String> dataSourceNames = new HashSet<String>() + // The datastore always creates the default connection source, whether or not it is configured + Set<String> dataSourceNames = [ConnectionSource.DEFAULT] as Set<String> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
