jdaugherty commented on PR #16462: URL: https://github.com/apache/grails-core/pull/16462#issuecomment-5935772430
@matrei this is the 8.0.x half of #16456, split out as you suggested in your review there: `GrailsAppBuilder` owning its hierarchy with covariant overrides (plus `build()` returning `GrailsApp`), the hierarchy-member flag on `GrailsApp` (package-scoped here, as you proposed), the development-watch guard, their specs, both example applications and a short section in "Executing the Application Class". The finding-2 log line is here too, since it belongs with the member check. The loan return, the second-application refusal, the run-status change and the full doc page stay in #16456, which now carries this branch as a merge so it applies cleanly once this is merged up. Could you review this one first? The specs here assert only what 8.0.x does: the parent holds the child's `grailsApplication` on loan while it runs, with no claim about what happens when the child closes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
