jamesfredley commented on issue #13202:
URL: https://github.com/apache/grails-core/issues/13202#issuecomment-5943634001

   This is fixed on `8.0.x`.
   
   The Tomcat failure — compiled GSP classes present in the WAR, but the view 
still unresolved, including `/error/error` — is the same defect as 
https://github.com/apache/grails-gradle-plugin/issues/257. `compileGroovyPages` 
took an unused `InputChanges` parameter, so Gradle treated the task as 
incremental and rewrote `gsp/views.properties` without pages compiled on an 
earlier pass. Adding `war { dependsOn compileGroovyPages }` only helped because 
it forced that task to run again and rewrite the index.
   
   The parameter was removed in d97f6c3f9b (2024-01-15, “Remove unused 
`InputChanges` parameter (#272)”). On current `8.0.x` (`d13aa332`):
   
   - `GroovyPageForkCompileTask.execute()` takes no `InputChanges` argument, so 
the task is not incremental.
   - `GroovyPagePlugin` makes every `War` and every `Jar`, including `bootJar`, 
depend on `compileGroovyPages`, and it packages the compiled pages.
   
   That code is in the 7.0.0 line (checked on `v7.0.0` and `v7.0.16`) and in 
`v8.0.0-M1` through `v8.0.0-RC2`. Closing as fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to