bito-code-review[bot] commented on PR #16480: URL: https://github.com/apache/grails-core/pull/16480#issuecomment-5972158866
<!-- Bito Reply --> The observation regarding the test coverage is accurate. Currently, the test only registers `UserTypeFlag` in the default mapping case, which does not fully verify that the mapping applies to every entity as intended. Additionally, the reliance on `typeNameOf` for scope distinction is correct, but as noted, a Boolean round-trip could potentially pass even if the custom type were not correctly bound. To improve the test coverage, it is recommended to: 1. Register and persist two distinct entities in the default mapping case to verify the global application of the user type. 2. Persist an unaffected entity in the class-local case to ensure the scope is correctly isolated. 3. Assert standard physical Boolean storage for both the unaffected and overridden properties to confirm the custom type is correctly bound and utilized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
