jdaugherty commented on PR #16486: URL: https://github.com/apache/grails-core/pull/16486#issuecomment-5996312192
@matrei thanks for the thorough review. Addressed in 3c5bd47ba6: 1. `release-publish-docs.yml` no longer passes `-PgithubBranch`, and the unused `TARGET_BRANCH` env is gone. The build takes `githubBranch` from the release commit's `gradle.properties`, so a corrected build links to the same branch as the voted zip. RELEASE.md now says so. 2. `release-verify.yml` now allows 180 minutes instead of 120. Smaller points: - Removed "Maximize build space" from the `docs` job. On RC1 that step took 90 seconds and freed about 15 GB of a 145 GB disk (104 GB free afterwards), so the website checkout fits without it. The correction workflow keeps it because it still builds. - `reset-verify.sh` now removes `apache-grails-<version>-docs`. - The vote email now gives the docs zip's size, computed in the `upload` job, e.g. `apache-grails-8.0.0-docs.zip (58MB)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
