matrei opened a new pull request, #16527: URL: https://github.com/apache/grails-core/pull/16527
Switches the test example apps that pinned their own webjars, or required them by a hardcoded version, to the jQuery and Bootstrap webjars managed by the `grails-bom`. Follow-up to the discussion in https://github.com/apache/grails-core/pull/16519#issuecomment-5999067824. ### Changes - **spring-security `cas/test1`** declared `org.webjars:bootstrap:3.3.6` and `org.webjars:jquery:2.2.0`, although its markup was already Bootstrap 5. It now uses `org.webjars.npm:bootstrap` and `org.webjars.npm:jquery` as `testAndDevelopmentOnly` dependencies without versions, like the other example apps. The Bootstrap 4 class `dropdown-menu-right` became `dropdown-menu-end`, and the leftover Bootstrap 3 caret spans are removed. - **spring-security `ldap/*`** (four apps) declared Bootstrap 4.1.3 and jQuery 3.3.1. They get the same dependency change. Their layout, welcome page and stylesheets came from an older `create-app` and were written against the Bootstrap 4 markup, so they now use the same Bootstrap 5 layout, welcome page and stylesheets as the cas app. The `main.css`, `mobile.css` and footer images that only the old layout used are removed. Most of the deleted lines come from this. - **`mail` and `redis`** already used the BOM-managed webjars, but required the assets by version (`webjars/jquery/3.7.1/...`, `webjars/bootstrap/5.3.3/...`, `webjars/bootstrap-icons/1.11.3/...`). The BOM manages Bootstrap 5.3.8 and Bootstrap Icons 1.13.1, so those paths no longer matched what was on the classpath. All require directives now use a `%` in place of the version directory, as applications generated by `create-app` do (e.g. `//= require webjars/jquery/%/dist/jquery.js`). The spring-security-ui plugin's own webjars are not changed, since the plugin is a published artifact. ### Verification - `integrationTest` passes for the four ldap apps, `mail` and `redis`. `cas/test1` has no integration tests. - `assetCompile` for all seven apps; the compiled `application.js` / `application.css` contain jQuery 3.7.1 and Bootstrap 5.3.8 (and Bootstrap Icons for `mail`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
