The GitHub Actions job "CI" on grails-core.git/feat/startup-progress-page has 
failed.
Run started by GitHub user jdaugherty (triggered by jdaugherty).

Head commit for run:
70b4ab40ebee7c502a19e0e99c9a020b21e847ef / James Daugherty 
<[email protected]>
Clarify what grails run-app waits for with the startup progress page

The availability check grails run-app makes reacts only to the
Grails-Startup-Phase header, which only the grails-startup-progress module
sends, so an application without the module is treated as before. Once the
embedded server has the port, the module's filter passes run-app's plain
HEAD / through to the application, so run-app stops waiting there, as it
always has, and does not wait for BootStrap.

- Say so in the ServerInteraction Javadoc and the guide, which read as if
  every application served the page.
- Replace the ServerInteractionSpec case for an answer the module never gives
  that request with the failed start it does answer.
- Check in StartupProgressSpec that the request run-app makes reaches the
  application while the startup hooks run.

Report URL: https://github.com/apache/grails-core/actions/runs/37409231647

With regards,
GitHub Actions via GitBox

Reply via email to