codeconsole commented on PR #16414: URL: https://github.com/apache/grails-core/pull/16414#issuecomment-6063974223
@matrei Thanks for re-checking, and for confirming the sort order. The five threads have replies. Your smaller items are done: - **`EXISTING_PROPERTY`:** section 2 now says that with `include = EXISTING_PROPERTY` the type id is the property's value, so it's written only when that property is persistent, and a transient or computed one isn't (5536958955). - **`Iterable`:** I dropped the `Iterable` clause from `isContainer`, as you suggested, together with the `Path` special case (26f1dda9ff). Collections and bean-like iterables still go to the Grails marshallers through their container or bean serializers. `Path` and `JsonNode` now reach the mapper. `JsonNode` is in `JsonMapperRenderingSpec`'s comparison with the mapper's text, and in the guide's table. - **`legacy` with `domain.jackson.enabled`:** the legacy section now says the converter still renders as Grails 8 did, and the application's `JsonMapper` renders domain classes with the module. **Verification:** 3,772 tests, 0 failures, all run fresh, across the same 12 suites as before, including the full `app1` and `hibernate7/app1` functional suites. `Grails8JsonRenderingSpec` still matches the 8.0.x text. `codeStyle` passes, and the guide builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
