borinquenkid opened a new pull request, #16569: URL: https://github.com/apache/grails-core/pull/16569
Second PR of the native domain binding stack (on top of the opt-in PR; followed by the deletion of the classic binder). 5 commits. ## What `hibernate.generatedDomainClasses` now defaults to **`true`**: an upgraded application binds its domain classes natively without any setting. `false` still selects the classic binder and logs one WARN per data source that the classic binding is deprecated and will be removed. ## Changes * Default flipped in `HibernateConnectionSourceSettings`, in `HibernateMappingContextConfiguration` (for callers that construct it directly) and in the Spring configuration metadata, which was missing the key. * Deprecation WARN when the classic binder is selected, with a spec that boots with `false`, with the default and with `true`. * Test infrastructure inverted: the suite runs natively by default; `-Pgrails.test.classicDomainBinding=true` runs the classic binder; `classic-only-specs.txt` lists the five specs that only make sense with the classic binder (two binder-fact specs, three pins of classic defects). Eleven specs that were excluded from the generated run turned out to pass natively and now run in the default mode, among them the generator differential. * A generator gap found by the example apps is closed: a composite identifier that includes the tenant id (`id composite: ['id', 'tenantId']` on a multi-tenant entity) was refused and is now accepted, with a failing-first spec. * One new documented schema difference: `dbm-generate-gorm-changelog` lists a new table's columns as identifier, then properties by name, then foreign keys (Hibernate's `PropertyContainer` orders attributes by name when no schema action runs). `dbm-gorm-diff` is unaffected because Liquibase does not compare column order. * Docs: manual chapter (default and fallback), configuration reference, migration checklist, upgrade notes §1.3/1.4, module README. ## Verification At the tip: core 4,597 tests native / 4,822 classic, 0 failures; dbmigration-core 40, dbmigration 112 + 93 CLI, plugin 39 + 2, spring-boot 2; both differentials unchanged (0 mismatches; 85 known, 0 unknown, 0 refused); the 22 Hibernate 7 example apps green in the new default except `app1`, whose 21 integration failures (GSP tag library, forwarding, upload) are identical with the classic binder forced and predate this stack. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
