borinquenkid commented on PR #16573: URL: https://github.com/apache/grails-core/pull/16573#issuecomment-6103606289
Thanks for the fix, @ruthst00, I appreciate it. While reviewing I saw an opportunity to refactor and improve the coverage, so I pushed one commit on top of your branch (5d5d37b954). It moves the alias registration out of `JpaCriteriaQueryCreator` into a package-private `QueryAliasRegistrar`. The duplicated block in `createQuery()` and `populateSubquery()` is now one call, and the behaviour is unchanged. `QueryAliasRegistrarSpec` adds 10 database-free unit specs for the join types and alias discovery. Your `CreateAliasJoinSpec` and the existing `JpaCriteriaQueryCreatorSpec` still pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
