codecov[bot] commented on PR #16589: URL: https://github.com/apache/grails-core/pull/16589#issuecomment-6104500773
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16589?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `49.00133%` with `766 lines` in your changes missing coverage. Please review. :warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`refactor/java-to-groovy-grails-datamapping-core@514d197`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report. | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16589?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../groovy/org/grails/buffer/GrailsPrintWriter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fbuffer%2FGrailsPrintWriter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYnVmZmVyL0dyYWlsc1ByaW50V3JpdGVyLmdyb292eQ==) | 48.2014% | [117 Missing and 27 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...n/groovy/org/grails/buffer/StreamByteBuffer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fbuffer%2FStreamByteBuffer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYnVmZmVyL1N0cmVhbUJ5dGVCdWZmZXIuZ3Jvb3Z5) | 40.6091% | [97 Missing and 20 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/grails/buffer/GrailsRoutablePrintWriter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fbuffer%2FGrailsRoutablePrintWriter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYnVmZmVyL0dyYWlsc1JvdXRhYmxlUHJpbnRXcml0ZXIuZ3Jvb3Z5) | 22.4638% | [104 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/grails/buffer/GrailsPrintWriterAdapter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fbuffer%2FGrailsPrintWriterAdapter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYnVmZmVyL0dyYWlsc1ByaW50V3JpdGVyQWRhcHRlci5ncm9vdnk=) | 19.6429% | [88 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...y/org/grails/buffer/StringCharArrayAccessor.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fbuffer%2FStringCharArrayAccessor.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYnVmZmVyL1N0cmluZ0NoYXJBcnJheUFjY2Vzc29yLmdyb292eQ==) | 14.8936% | [40 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...groovy/org/grails/encoder/EncodingStateImpl.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2FEncodingStateImpl.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9FbmNvZGluZ1N0YXRlSW1wbC5ncm9vdnk=) | 48.7805% | [20 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...y/org/grails/encoder/DefaultCodecIdentifier.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2FDefaultCodecIdentifier.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9EZWZhdWx0Q29kZWNJZGVudGlmaWVyLmdyb292eQ==) | 25.9259% | [19 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...vy/org/grails/encoder/impl/BasicJSONEncoder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2Fimpl%2FBasicJSONEncoder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9pbXBsL0Jhc2ljSlNPTkVuY29kZXIuZ3Jvb3Z5) | 23.0769% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...y/org/grails/encoder/impl/JavaScriptEncoder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2Fimpl%2FJavaScriptEncoder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9pbXBsL0phdmFTY3JpcHRFbmNvZGVyLmdyb292eQ==) | 48.5714% | [16 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...oovy/org/grails/charsequences/CharSequences.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fcharsequences%2FCharSequences.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvY2hhcnNlcXVlbmNlcy9DaGFyU2VxdWVuY2VzLmdyb292eQ==) | 52.7778% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [28 more](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## refactor/java-to-groovy-grails-datamapping-core #16589 +/- ## ==================================================================================== Coverage ? 62.8706% Complexity ? 29789 ==================================================================================== Files ? 2221 Lines ? 109183 Branches ? 20214 ==================================================================================== Hits ? 68644 Misses ? 31161 Partials ? 9378 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16589?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...n/groovy/org/grails/buffer/StreamCharBuffer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fbuffer%2FStreamCharBuffer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvYnVmZmVyL1N0cmVhbUNoYXJCdWZmZXIuZ3Jvb3Z5) | `62.9908% <ø> (ø)` | | | [...n/groovy/org/grails/encoder/impl/HTML4Codec.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2Fimpl%2FHTML4Codec.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9pbXBsL0hUTUw0Q29kZWMuZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | | | [.../groovy/org/grails/encoder/impl/HTMLEncoder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2Fimpl%2FHTMLEncoder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9pbXBsL0hUTUxFbmNvZGVyLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | | | [.../groovy/org/grails/encoder/impl/HTMLJSCodec.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2Fimpl%2FHTMLJSCodec.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9pbXBsL0hUTUxKU0NvZGVjLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | | | [...in/groovy/org/grails/encoder/ChainedDecoder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2FChainedDecoder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9DaGFpbmVkRGVjb2Rlci5ncm9vdnk=) | `81.8182% <88.8889%> (ø)` | | | [...groovy/org/grails/encoder/CodecLookupHelper.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2FCodecLookupHelper.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9Db2RlY0xvb2t1cEhlbHBlci5ncm9vdnk=) | `66.6667% <83.3333%> (ø)` | | | [...s/encoder/EncodingStateRegistryLookupHolder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2FEncodingStateRegistryLookupHolder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9FbmNvZGluZ1N0YXRlUmVnaXN0cnlMb29rdXBIb2xkZXIuZ3Jvb3Z5) | `50.0000% <75.0000%> (ø)` | | | [...groovy/org/grails/encoder/impl/HTML4Decoder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2Fimpl%2FHTML4Decoder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9pbXBsL0hUTUw0RGVjb2Rlci5ncm9vdnk=) | `50.0000% <66.6667%> (ø)` | | | [.../org/grails/encoder/CombinedCodecIdentifier.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2FCombinedCodecIdentifier.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9Db21iaW5lZENvZGVjSWRlbnRpZmllci5ncm9vdnk=) | `78.9474% <84.6154%> (ø)` | | | [...vy/org/grails/encoder/WriterEncodedAppender.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree&filepath=grails-encoder%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fencoder%2FWriterEncodedAppender.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWVuY29kZXIvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZW5jb2Rlci9Xcml0ZXJFbmNvZGVkQXBwZW5kZXIuZ3Jvb3Z5) | `71.4286% <75.0000%> (ø)` | | | ... and [32 more](https://app.codecov.io/gh/apache/grails-core/pull/16589?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
