jdaugherty commented on PR #439: URL: https://github.com/apache/grails-intellij-plugin/pull/439#issuecomment-6107056436
Thanks for working through the review. I checked 5120d72. The project-view tests pass, and if I move the title write into `updateImpl`, the new `testTitleSurvivesProjectViewDecorators` fails with `[Tests:unit , [app.test]]`, so it catches the regression. I pushed 329ca6e to fix two remaining wording nits: - The inline comment in `GrailsNodeProviderTestSupport.rendered()` still said `update()` runs `updateImpl` and then `postprocess`. It now names the decorator step, matching the javadoc above it. - AGENTS.md offered calling `updateImpl` and then `postprocess` directly as an alternative to `update()`. It now says that route skips the decorators, so it should only be used to check the platform's fragments before the title replaces them. I also retitled the PR to describe the change. I'll squash on merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
