codecov[bot] commented on PR #16604: URL: https://github.com/apache/grails-core/pull/16604#issuecomment-6110189680
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16604?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `57.63657%` with `380 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.8398%. Comparing base ([`d5e670c`](https://app.codecov.io/gh/apache/grails-core/commit/d5e670ce03cbb84f7c8e92129fd9d3763e17ce23?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07c4880`](https://app.codecov.io/gh/apache/grails-core/commit/07c4880c8bf706b82a39327fd20ff85eaff6130c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16604?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../grails/web/gsp/GroovyPagesTemplateRenderer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fgsp%2FGroovyPagesTemplateRenderer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvZ3NwL0dyb292eVBhZ2VzVGVtcGxhdGVSZW5kZXJlci5ncm9vdnk=) | 40.8163% | [50 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...io/CachingGrailsConventionGroovyPageLocator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fgsp%2Fio%2FCachingGrailsConventionGroovyPageLocator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvZ3NwL2lvL0NhY2hpbmdHcmFpbHNDb252ZW50aW9uR3Jvb3Z5UGFnZUxvY2F0b3IuZ3Jvb3Z5) | 29.4118% | [41 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...oovy/org/grails/web/pages/GSPResponseWriter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fpages%2FGSPResponseWriter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvcGFnZXMvR1NQUmVzcG9uc2VXcml0ZXIuZ3Jvb3Z5) | 39.4366% | [41 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ils/web/servlet/view/GroovyPageViewResolver.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fview%2FGroovyPageViewResolver.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvc2VydmxldC92aWV3L0dyb292eVBhZ2VWaWV3UmVzb2x2ZXIuZ3Jvb3Z5) | 66.3793% | [25 Missing and 14 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...servlet/context/GrailsWebApplicationContext.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fweb%2Fservlet%2Fcontext%2FGrailsWebApplicationContext.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9ncmFpbHMvd2ViL3NlcnZsZXQvY29udGV4dC9HcmFpbHNXZWJBcHBsaWNhdGlvbkNvbnRleHQuZ3Jvb3Z5) | 38.0952% | [36 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...eb/gsp/io/GrailsConventionGroovyPageLocator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fgsp%2Fio%2FGrailsConventionGroovyPageLocator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvZ3NwL2lvL0dyYWlsc0NvbnZlbnRpb25Hcm9vdnlQYWdlTG9jYXRvci5ncm9vdnk=) | 51.2820% | [34 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/grails/web/servlet/view/GroovyPageView.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fview%2FGroovyPageView.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvc2VydmxldC92aWV3L0dyb292eVBhZ2VWaWV3Lmdyb292eQ==) | 31.4815% | [35 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ntext/support/WebRuntimeSpringConfiguration.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fcontext%2Fsupport%2FWebRuntimeSpringConfiguration.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3dlYi9zZXJ2bGV0L2NvbnRleHQvc3VwcG9ydC9XZWJSdW50aW1lU3ByaW5nQ29uZmlndXJhdGlvbi5ncm9vdnk=) | 29.6296% | [15 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/grails/web/errors/GrailsExceptionResolver.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Ferrors%2FGrailsExceptionResolver.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2Vycm9ycy9HcmFpbHNFeGNlcHRpb25SZXNvbHZlci5ncm9vdnk=) | 87.7551% | [15 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ovy/org/grails/web/pages/GroovyPagesServlet.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fpages%2FGroovyPagesServlet.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvcGFnZXMvR3Jvb3Z5UGFnZXNTZXJ2bGV0Lmdyb292eQ==) | 67.3077% | [16 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [7 more](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## refactor/java-to-groovy-grails-web-url-mappings #16604 +/- ## ========================================================================================= + Coverage 62.7483% 62.8398% +0.0914% - Complexity 31156 31244 +88 ========================================================================================= Files 2216 2216 Lines 108218 108164 -54 Branches 20400 20399 -1 ========================================================================================= + Hits 67905 67970 +65 + Misses 30567 30451 -116 + Partials 9746 9743 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16604?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...b/servlet/boostrap/BootstrapArtefactHandler.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fboostrap%2FBootstrapArtefactHandler.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3dlYi9zZXJ2bGV0L2Jvb3N0cmFwL0Jvb3RzdHJhcEFydGVmYWN0SGFuZGxlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...g/grails/web/filters/HiddenHttpMethodFilter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Ffilters%2FHiddenHttpMethodFilter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2ZpbHRlcnMvSGlkZGVuSHR0cE1ldGhvZEZpbHRlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [.../org/grails/web/servlet/GrailsUrlPathHelper.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2FGrailsUrlPathHelper.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvR3JhaWxzVXJsUGF0aEhlbHBlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...eb/servlet/mvc/AbstractTokenResponseHandler.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fmvc%2FAbstractTokenResponseHandler.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvbXZjL0Fic3RyYWN0VG9rZW5SZXNwb25zZUhhbmRsZXIuZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | | | [...b/servlet/context/support/GrailsEnvironment.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fweb%2Fservlet%2Fcontext%2Fsupport%2FGrailsEnvironment.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9ncmFpbHMvd2ViL3NlcnZsZXQvY29udGV4dC9zdXBwb3J0L0dyYWlsc0Vudmlyb25tZW50Lmdyb292eQ==) | `92.3077% <92.3077%> (ø)` | | | [...rails/web/servlet/context/GrailsConfigUtils.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fcontext%2FGrailsConfigUtils.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3dlYi9zZXJ2bGV0L2NvbnRleHQvR3JhaWxzQ29uZmlnVXRpbHMuZ3Jvb3Z5) | `96.1538% <94.4444%> (ø)` | | | [...ervlet/boostrap/DefaultGrailsBootstrapClass.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fboostrap%2FDefaultGrailsBootstrapClass.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3dlYi9zZXJ2bGV0L2Jvb3N0cmFwL0RlZmF1bHRHcmFpbHNCb290c3RyYXBDbGFzcy5ncm9vdnk=) | `90.9091% <90.9091%> (ø)` | | | [...groovy/org/grails/web/servlet/view/NullView.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-gsp%2Fgrails-web-gsp%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fview%2FNullView.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtd2ViLWdzcC9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy93ZWIvc2VydmxldC92aWV3L051bGxWaWV3Lmdyb292eQ==) | `0.0000% <0.0000%> (ø)` | | | [...ails/web/servlet/mvc/GrailsWebRequestFilter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-mvc%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2Fmvc%2FGrailsWebRequestFilter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1tdmMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvbXZjL0dyYWlsc1dlYlJlcXVlc3RGaWx0ZXIuZ3Jvb3Z5) | `84.3750% <86.9565%> (ø)` | | | [...rc/main/groovy/grails/spring/WebBeanBuilder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree&filepath=grails-web-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fspring%2FWebBeanBuilder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb3JlL3NyYy9tYWluL2dyb292eS9ncmFpbHMvc3ByaW5nL1dlYkJlYW5CdWlsZGVyLmdyb292eQ==) | `0.0000% <0.0000%> (ø)` | | | ... and [11 more](https://app.codecov.io/gh/apache/grails-core/pull/16604?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16604/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
