jdaugherty commented on PR #16626:
URL: https://github.com/apache/grails-core/pull/16626#issuecomment-6146914638
@matrei all four points are in, as a single amended commit:
1. The Byte Buddy and OpenTelemetry pin comments now say the pins keep the
BOM authoritative for the versions Selenium pulls in on every classpath, and
that they can go back to Boot's versions with the Selenium pin.
2. The Testing guide no longer just links to the README: it gained a
"Browser Container Image" section with the default image, the arm64 note, the
`containerBrowser` example, and the `grails.geb.container.image.template`
property. The README link now uses the `{githubBranch}` attribute the docs
build already carries, so it follows the maintenance branch instead of being
hard-coded.
3. The README and the guide note that `standalone-firefox` has been arm64
for longer, `standalone-edge` is amd64-only at 4.49.0, and overriding
`selenium.version` below 4.47.0 brings back the amd64-only Chrome image.
4. The `selenium.version` comment mentions why `selenium-htmlunit.version`
stays at Boot's 4.43.0.
`validateDependencyVersions`, `validateBomProperties`,
`:grails-geb:codeStyle` and `:grails-doc:publishGuide` pass locally; the new
section, the cross-reference and the resolved branch link are in the rendered
guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
