jdaugherty commented on code in PR #445:
URL:
https://github.com/apache/grails-intellij-plugin/pull/445#discussion_r4289550668
##########
plugin/src/main/java/org/apache/grails/intellij/plugin/util/GrailsArtifact.java:
##########
@@ -80,7 +81,16 @@ public enum GrailsArtifact {
DOMAIN(NotNullLazyValue.createValue(() -> AllIcons.Nodes.DataTables), "",
"domain"),
CONTROLLER(NotNullLazyValue.createValue(() -> AllIcons.Nodes.Controller),
"Controller", "controllers"),
TAGLIB(NotNullLazyValue.createValue(() -> GroovyMvcIcons.Taglib), "TagLib",
"taglib"),
- SERVICE(NotNullLazyValue.createValue(() -> AllIcons.FileTypes.Config),
"Service", "services"),
+ SERVICE(NotNullLazyValue.createValue(() -> AllIcons.FileTypes.Config),
"Service", "services") {
+ /**
+ * A GORM data service is an interface annotated with {@code
grails.gorm.services.Service}; GORM
+ * generates the implementation at compile time, so the interface is the
only source artefact.
Review Comment:
Good catch, thanks. Reworded in af60dd8 along the lines of your suggestion,
with the reason spelled out (the annotation may not resolve). Also added
`testUnannotatedServiceInterfaceIsAServiceArtefact` so the documented behaviour
is pinned: a plain `interface PricingService` under `grails-app/services` is
recognised as a service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
