amondel2 commented on code in PR #441: URL: https://github.com/apache/grails-intellij-plugin/pull/441#discussion_r4290190490
########## README.md: ########## @@ -8,6 +8,10 @@ integrations for i18n, coverage, Hibernate, Maven, and language injection. The Grails project view pane gives `grails-app/` dedicated **Stylesheets**, **Images**, **JavaScripts**, **Migrations**, **Translations** and **Utils** nodes, and lifts the test source roots out of `src` as **Tests:unit**, **Tests:integration** and **Tests:functional**. +Users can configure up to 3 custom folders — global defaults with a per-project override — +that appear as nodes below the test nodes in the Grails view. Custom folders can only Review Comment: The three places now state one rule, and I checked the two claims you asked about rather than restating either side. **Hidden directories: the claim was wrong and the docs were wrong.** The default *Ignored Files and Folders* list holds named entries and glob suffixes (`.git`, `*.pyc`, `*~`) and has no rule covering dot-directories as a class, so `.github` resolves and renders as a real expandable folder node. `testHiddenDotDirectoryRendersAsAnExpandableFolderNode` asserts both halves — `.github` is not ignored while `.git` is — so the README and §2.8 cannot drift back to an unverified generalisation. The checkbox asking for hidden-directory support is gone from §2.8 because there is nothing to support. **Absolute paths: these were used, and are now rejected.** You are right that the provider resolved them through `LocalFileSystem` and that the settings page said "used as-is". Rather than reconcile the two ways, I narrowed the feature to what the docs claimed: the provider now resolves a relative path against the application root and nothing else, the `LocalFileSystem` branch and `isAbsolute()` are deleted, and `apply()` rejects an absolute path, an escaping `..`, and a path resolving outside the root, naming the row. An absolute path outside the application now renders as a placeholder — `testAbsolutePathOutsideTheApplicationRendersAsPlaceholder` — and external directories stay a tracked follow-up in §2.8 rather than being silently dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
