jdaugherty commented on code in PR #16654:
URL: https://github.com/apache/grails-core/pull/16654#discussion_r4296238560
##########
grails-spring-security/compat/src/main/groovy/org/springframework/security/web/access/intercept/FilterSecurityInterceptor.groovy:
##########
@@ -51,6 +52,9 @@ class FilterSecurityInterceptor extends
AbstractSecurityInterceptor implements F
}
def authentication = SecurityContextHolder.context?.authentication
+ if (authentication == null) {
Review Comment:
Same guard and same message as the compat `MethodSecurityInterceptor`, which
is the consistency we want between the two shims.
Probe: with the 8.0.x version of this file, the `missing authentication` row
of the new chain spec fails with `java.lang.AssertionError: authentication
cannot be null` out of `WebExpressionVoter.vote`, the exact stack from #16632.
With this change it is a 401.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
