jdaugherty commented on PR #16625: URL: https://github.com/apache/grails-core/pull/16625#issuecomment-6219445152
Thanks for running the reverts, @borinquenkid. On (1): `hibernate.proxy_factory_class` is not a Hibernate setting (it is in neither 5.6 nor 7.4) and nothing in Grails reads it. The Groovy-aware factory is installed by default on both modules through `GrailsBytecodeProvider`: Hibernate 5 adds it as a provided `ProxyFactoryFactory` service, and Hibernate 7 passes it as `BYTECODE_PROVIDER_INSTANCE`. I removed the line from the Hibernate 7 application in c032daca86 and the spec still passes, so it now proves the default configuration, as the Hibernate 5 application already did. The same inert key sits in a few other Hibernate 7 test configurations; that is a separate cleanup. (3) and (4) are fixed in the same commit: the loan feature now reads the deserialized book through and asserts it loaded, as the standalone feature does, and the duplicate assertion is gone. (2) is Hibernate's own behaviour: without `enable_lazy_load_no_trans` a detached proxy throws `LazyInitializationException` on first load, and this change does not alter that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
