The GitHub Actions job "CI" on grails-core.git/refactor/java-to-groovy-grails-spring has failed. Run started by GitHub user borinquenkid (triggered by borinquenkid).
Head commit for run: 7640f1019c9424e6f39ec782789e1d6acae6d6f5 / Walter Duque de Estrada <[email protected]> refactor(grails-spring): keep semicolons to preserve rename history on 3 files DefaultBeanConfiguration.java, DefaultRuntimeSpringConfiguration.java, and GrailsApplicationContext.java converted at 41-45% similarity, below git's default 50% rename-similarity threshold used by GitHub's PR view and git log --follow/blame (matrei's review comment on #16576). Rebuilt each from the original .java content, keeping semicolons and every other Java-ism, applying only the CodeNarc-minimal set: dropped public modifier, unnecessary java.util/groovy.lang imports, flagged non-interpolated double-quoted strings, and unnecessary .class literal references. Added @SuppressWarnings('UnnecessarySemicolon') + explanatory comment on each class. GrailsApplicationContext needed one addition beyond the mechanical transform: it hand-implements GroovyObject (metaClass field, getMetaClass/setMetaClass/ getProperty/setProperty/invokeMethod), and without @POJO + @CompileStatic - both already present on this class's current (post-groovyism-cleanup) sibling - Groovy's compiler-synthesized metaclass scaffolding for a GroovyObject-implementing class races the explicit field assignment in the constructor, throwing a NullPointerException ('this.mc' is null) the first time a context is constructed. Confirmed via the full test suite: 3 DefaultRuntimeSpringConfigurationSpec failures without @POJO/@CompileStatic, 0 with them. Verification: compileGroovy clean; codenarcMain clean; full grails-spring test suite 21/21, 0 failures (matching baseline). Rename detection confirmed via git diff --name-status (default, no -M): R077-R083 for all 3 files. Co-Authored-By: Claude Sonnet 5 <[email protected]> Report URL: https://github.com/apache/grails-core/actions/runs/39084345709 With regards, GitHub Actions via GitBox
