The GitHub Actions job "CI" on grails-core.git/refactor/java-to-groovy-grails-datastore-core has succeeded. Run started by GitHub user borinquenkid (triggered by borinquenkid).
Head commit for run: cc1bc0a4021ff3fc80ffff6daaaf34bffbad0e3e / Walter Duque de Estrada <[email protected]> refactor(datastore-core): keep semicolons to preserve rename history on 57 files Rebuilds each of these 57 grails-datastore-core files from the original .java content with a minimal mechanical conversion (public removed from methods/class decls, unnecessary groovy auto-imports dropped, safe double-quote -> single-quote conversions) that deliberately keeps every semicolon, so git's default 50% rename-similarity threshold recognizes each as a rename of its .java predecessor instead of a delete+add, following the pattern proven on DefaultCommandLine.groovy (#16576).// Each file adds a scoped @SuppressWarnings('UnnecessarySemicolon') with an explanatory TODO, to be removed by the stacked groovyism-cleanup PR. A handful of files needed small additional, behavior-preserving fixes beyond the mechanical conversion, found by running the full test suite under @CompileStatic (matching the already-converted sibling code): Groovy's '==' operator calls equals() (AbstractPersistentEntity.equals used this.is(o) instead), Groovy's property-style getter/setter resolution prefers the nearest enclosing method of the same name over an outer-class field or the field itself (KeyValuePersistentEntity. getMappedForm, Query's Equals/IdEquals/NotEquals.setValue), a Java Class::methodRef bound to '.class' breaks once blanket dot-class removal strips it (Association.isHasOne), and two classes that override GroovyObject.getProperty(String) need @groovy.transform.stc.POJO so ordinary '.property' access is not routed through that override (BeanEntityAccess, FieldEntityAccess). GormProperties (a pure constants interface with no logic) and KeyValueMappingFactory needed a documented, targeted exception to clear the 50% threshold: GormProperties drops its semicolons entirely rather than keep them under a suppression that would push it below the threshold, and KeyValueMappingFactory omits @CompileStatic (no field/getter naming collision risk was found there). Verified: compileGroovy/compileTestGroovy clean, codenarcMain clean, and all 949 grails-datastore-core tests pass (same count as before, 0 failures), matching the pre-change baseline. All 57 files are now git-detected as R050+ renames against origin/10.0.x with git's default (no -M flag) similarity detection. Co-Authored-By: Claude Sonnet 5 <[email protected]> Report URL: https://github.com/apache/grails-core/actions/runs/39084342639 With regards, GitHub Actions via GitBox
